Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: clarify dematerialize() and terminal items/signals #5897

Merged
merged 1 commit into from
Mar 7, 2018
Merged

2.x: clarify dematerialize() and terminal items/signals #5897

merged 1 commit into from
Mar 7, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Mar 7, 2018

Specify in both Flowable and Observable that a terminal notification item or a regular terminal signal ends the flow.

Fixes: #5261

@akarnokd akarnokd added this to the 2.2 milestone Mar 7, 2018
@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #5897 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5897      +/-   ##
============================================
- Coverage     97.92%   97.89%   -0.03%     
  Complexity     5985     5985              
============================================
  Files           655      655              
  Lines         43836    43836              
  Branches       6072     6072              
============================================
- Hits          42926    42914      -12     
- Misses          278      287       +9     
- Partials        632      635       +3
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 557 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 535 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 90.19% <0%> (-4.58%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 93.04% <0%> (-4.35%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 92.98% <0%> (-3.51%) 11% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.92%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 96.23% <0%> (-2.69%) 54% <0%> (ø)
.../operators/mixed/FlowableConcatMapCompletable.java 97.43% <0%> (-2.57%) 2% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb05a26...15b8500. Read the comment docs.

@akarnokd akarnokd merged commit 95dde6f into ReactiveX:2.x Mar 7, 2018
@akarnokd akarnokd deleted the DematerializeJavaDoc branch March 7, 2018 11:06
@akarnokd akarnokd mentioned this pull request Mar 15, 2018
Closed
This was referenced Mar 20, 2018
Closed
Closed
@jared-bot jared-bot mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
2.x Documentation
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @vanniktech